-
-
Notifications
You must be signed in to change notification settings - Fork 240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to JupyterLab 3.0 #102
Conversation
I'm updating the docs to use https://mybinder.org/v2/gh/jupyterlab/jupyterlab-demo/8f2ecb6?urlpath=lab/tree/demo in jupyterlab/jupyterlab#9546 |
After a few seconds on that image, I get this dialog: Build Recommended jupyter-offlinenotebook needs to be included in build Can we remove that plugin too, or rebuild as part of the image? |
I can't see where we are pulling in that extension. Is it part of the base binder image? |
Yes, it's in the default repo2docker scripts. I'm going to update it to a new version that works with both JL 2 and 3, and use the new pre-built extensions system so it won't require a rebuild for JL3. |
Yes it is part of the base image and installed here: When the switch to JupyterLab 3.0 is done in repo2docker (jupyterhub/repo2docker#996) this should normally not be an issue anymore since the offline notebook extension will be prebuilt. |
Wondering why the popup still shows up though, since there should also be an explicit build right after: |
Probably because it is never incorporated into lab 3 or something? We could install the newest version of that package, which supports jlab 3 now (as of an hour ago, 0.2.0 was published) |
The latest commit explicitly installs https://mybinder.org/v2/gh/jupyterlab/jupyterlab-demo/3818244?urlpath=lab |
I updated jupyterlab/jupyterlab#9546 to use this new link |
See jupyterlab/jupyterlab-demo#102 for more discussion.
Looks good with the jupyterlab renderers: I think it's mostly |
Also it seems like the Binder doesn't open with the predefined workspace anymore. So something to have a look at too, also to make sure it's not a regression. |
For anyone willing to test the latest changes, here is the link to the Binder for this PR: https://mybinder.org/v2/gh/jupyterlab/jupyterlab-demo/lab3?urlpath=lab |
- tensorflow=1.13 | ||
- sympy=1.4 | ||
- pyyaml | ||
- traittypes==0.2.1 | ||
- invoke=1.2 | ||
# C++ Kernel | ||
- xeus-cling=0.6 | ||
- xeus-cling=0.10 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To answer your question @SylvainCorlay, this syntax installs 0.10.1
:
This issue might be relevant: jupyterlab/jupyterlab#9186 |
Just added Apart from the workspace restoration issue mentioned above, everything should work as before. We might also want to remove |
Just opened jupyterlab/jupyterlab#9590 as it looks like there might be an issue with the restorer? |
Marking as ready for review, so the workspace issue could be addressed separately. Instead, we can update the URL to open the https://mybinder.org/v2/gh/jupyterlab/jupyterlab-demo/lab3?urlpath=lab/tree/demo/Lorenz.ipynb |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me!
I tried out this branch and seems good.
I agree with @jtpio, to merge this and not block on the upstream JupyterLab 3.0 workspace issue (jupyterlab/jupyterlab#9590).
I agree, thanks @saulshanabrook! |
Replaces #101
Fixes #100
For now commenting out some extensions that have not been updated yet.
Can be tested with this link: https://mybinder.org/v2/gh/jupyterlab/jupyterlab-demo/lab3?urlpath=lab
TODO
ipyleaflet
bqplot
jupyterlab-renderers