-
Notifications
You must be signed in to change notification settings - Fork 318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace MUI Components with Jupyterlab UI toolkit #1301
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @Zxun2
Thanks for working on this. I see that you are based on the main branch prior to the migration to JupyterLab 4. Would you mind migrating to the main
branch latest commit?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Zxun2
The action buttons are too big by default. I got something more acceptable by setting the following CSS property in actionButtonStyle
(src/style/ActionButtonStyle.ts):
// @ts-expect-error unknown prop
'--density': -1,
<> | ||
<Tooltip anchor={title}>{title}</Tooltip> | ||
<Button | ||
id={title} | ||
className={classes(actionButtonStyle, className)} | ||
disabled={disabled} | ||
onClick={onClick} | ||
> | ||
<icon.react elementPosition="center" tag="span" /> | ||
</Button> | ||
</> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would simply keep the title without introducing a tooltip
<> | |
<Tooltip anchor={title}>{title}</Tooltip> | |
<Button | |
id={title} | |
className={classes(actionButtonStyle, className)} | |
disabled={disabled} | |
onClick={onClick} | |
> | |
<icon.react elementPosition="center" tag="span" /> | |
</Button> | |
</> | |
<Button | |
title={title} | |
className={classes(actionButtonStyle, className)} | |
disabled={disabled} | |
onClick={onClick} | |
> | |
<icon.react elementPosition="center" tag="span" /> | |
</Button> |
Changes