Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix memory leaks #12750

Merged

Conversation

fcollonval
Copy link
Member

References

Follow-up of jupyterlab/benchmarks#100 that introduces memory leaks analysis

Code changes

  • Remove widget.id from various mapping
  • Disconnect correctly signals following notebook switch in cell tags
  • Dispose the sharedModel when switching it
  • Dispose modelDB when a model is disposed
  • Release disposable items in open with menu in context menu
  • Clear settings connection in execution indicator

User-facing changes

None

Backwards-incompatible changes

N/A

@jupyterlab-probot
Copy link

Thanks for making a pull request to jupyterlab!
To try out this branch on binder, follow this link: Binder

@fcollonval fcollonval merged commit 6bf3f3b into jupyterlab:master Jul 6, 2022
@fcollonval fcollonval deleted the maintenance/notebook-memory-leaks branch July 6, 2022 06:18
@fcollonval
Copy link
Member Author

@meeseeksdev please backport to 3.4.x

@lumberbot-app
Copy link

lumberbot-app bot commented Jul 6, 2022

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
git checkout 3.4.x
git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
git cherry-pick -x -m1 6bf3f3b285f238b28e8e3b47e3f3a65249c41513
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
git commit -am 'Backport PR #12750: Fix memory leaks'
  1. Push to a named branch:
git push YOURFORK 3.4.x:auto-backport-of-pr-12750-on-3.4.x
  1. Create a PR against branch 3.4.x, I would have named this PR:

"Backport PR #12750 on branch 3.4.x (Fix memory leaks)"

And apply the correct labels and milestones.

Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove the Still Needs Manual Backport label once the PR gets merged.

If these instructions are inaccurate, feel free to suggest an improvement.

fcollonval added a commit that referenced this pull request Jul 7, 2022
* Backport PR #12750: Fix memory leaks

* Fix TS config

* Bumping puppeteer
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants