-
-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Delay list -> dict conversation to end #192
Conversation
Codecov Report
@@ Coverage Diff @@
## main #192 +/- ##
==========================================
+ Coverage 77.48% 77.93% +0.45%
==========================================
Files 28 28
Lines 2105 2121 +16
==========================================
+ Hits 1631 1653 +22
+ Misses 474 468 -6
Continue to review full report at Codecov.
|
This should prevent dicts in webapp data from being clobbered by converted lists from the settings_dir.
I haven't yet, but it shouldn't be a problem for us. Thanks for the heads up. |
Should this be considered a breaking change? After investigating the JupyterLab CI failure in jupyterlab/jupyterlab#11744, it looks like consumers retrieving the page config with This could be fixed in lab, but would need to be able to handle both dicts and lists to allow for various combinations of |
This reverts commit 7b9c024.
This should prevent dicts in webapp data from being clobbered by converted lists from the settings_dir.
Fixes #191 .