Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove mouse event handlers from SplitPanel #327

Merged
merged 1 commit into from
Aug 4, 2022
Merged

Remove mouse event handlers from SplitPanel #327

merged 1 commit into from
Aug 4, 2022

Conversation

afshin
Copy link
Member

@afshin afshin commented Aug 4, 2022

Continuation of Lumino 2 deprecated code removal: this PR removes mouse event handlers from SplitPanel and leaves only pointer event handlers.

@afshin afshin added the maintenance Dependencies, build, technical debt, etc. label Aug 4, 2022
@afshin afshin added this to the Lumino 2 milestone Aug 4, 2022
@afshin afshin self-assigned this Aug 4, 2022
blink1073
blink1073 approved these changes Aug 4, 2022
View reviewed changes
Copy link
Contributor

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

fcollonval
fcollonval approved these changes Aug 4, 2022
View reviewed changes
Copy link
Member

@fcollonval fcollonval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @afshin

@fcollonval fcollonval merged commit b89af36 into jupyterlab:main Aug 4, 2022
@afshin afshin mentioned this pull request Aug 4, 2022
Closed
16 tasks
@afshin afshin removed their assignment Aug 8, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@blink1073 blink1073 blink1073 approved these changes

@fcollonval fcollonval fcollonval approved these changes

Assignees
No one assigned
Labels
maintenance Dependencies, build, technical debt, etc.
Projects
No open projects
Lumino 2
Status: done
Milestone
Lumino 2
Development

Successfully merging this pull request may close these issues.
3 participants
@afshin @blink1073 @fcollonval