Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure package is installed with test files in test-sdist #114

Merged
merged 1 commit into from
Aug 11, 2022
Merged

Ensure package is installed with test files in test-sdist #114

merged 1 commit into from
Aug 11, 2022

Conversation

marmitar
Copy link
Contributor

Install package in --editable mode to ensure test files are present. Solves #113.

@welcome
Copy link

welcome bot commented Aug 11, 2022

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly.
welcome
You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

@blink1073 blink1073 added the bug Something isn't working label Aug 11, 2022
blink1073
blink1073 approved these changes Aug 11, 2022
View reviewed changes
Copy link
Contributor

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@blink1073 blink1073 merged commit 5a9b3a2 into jupyterlab:main Aug 11, 2022
@welcome
Copy link

welcome bot commented Aug 11, 2022

Congrats on your first merged pull request in this project! 🎉
congrats
Thank you for contributing, we are very proud of you! ❤️

@blink1073
Copy link
Contributor

I'll cut a new release early next week.

@marmitar marmitar deleted the no-binary-in-test-sdist branch August 11, 2022 22:43
@blink1073
Copy link
Contributor

https://github.com/jupyterlab/maintainer-tools/releases/tag/v0.11.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blink1073 blink1073 blink1073 approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marmitar @blink1073