Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix package_download_extra_args #147

Merged
merged 3 commits into from
Nov 11, 2022
Merged

Fix package_download_extra_args #147

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3a05e10
try without default arg
blink1073 Nov 11, 2022
0eee438
fix variable name
blink1073 Nov 11, 2022
236ba81
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Nov 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions .github/actions/downstream-test/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,6 @@ inputs:
required: true
package_download_extra_args:
description: "The arguments used to download the package"
required: true
default: ""
test_command:
description: "The test command"
default: "pytest -vv -raXxs --durations 10 --color=yes"
Expand All @@ -32,7 +30,7 @@ runs:
package_name=${{inputs.package_name}}
package_spec="${{inputs.package_spec}}"
test_command="${{inputs.test_command}}"
package_download_extra_args="${{inputs.package_download_args}}"
package_download_extra_args="${{inputs.package_download_extra_args}}"
root=$(pwd)
eval "${{inputs.env_values}}"
echo "::endgroup::"
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,4 @@
"name": "@jupyterlab/maintainer-tools",
"version": "0.17.0",
"private": true
}
}