Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix continue-on-error configuration #178

Merged
merged 1 commit into from
Jan 18, 2023
Merged

Fix continue-on-error configuration #178

merged 1 commit into from
Jan 18, 2023

Conversation

fcollonval
Copy link
Member

continue-on-error is not working as I forgot inputs are strings.

See error in that run: https://github.com/jupyterlab/jupyterlab/actions/runs/3940040404/jobs/6740639988

 Error: jupyterlab/maintainer-tools/v1/.github/actions/update-snapshots/action.yml (Line: 80, Col: 26): Unexpected value 'true'
Error: The step failed and an error occurred when attempting to determine whether to continue on error.
Error: The template is not valid. jupyterlab/maintainer-tools/v1/.github/actions/update-snapshots/action.yml (Line: 80, Col: 26): Unexpected value 'true'

@fcollonval fcollonval added the bug Something isn't working label Jan 18, 2023
blink1073
blink1073 approved these changes Jan 18, 2023
View reviewed changes
Copy link
Contributor

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@blink1073 blink1073 merged commit ca49609 into jupyterlab:main Jan 18, 2023
@fcollonval fcollonval deleted the fix/continue-on-error branch January 18, 2023 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blink1073 blink1073 blink1073 approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fcollonval @blink1073