Add more linting

.github/actions/check-links/check_links.py

@@ -12,7 +12,7 @@ def log(*outputs, **kwargs):
     print(*outputs, **kwargs)
 
 
-def check_links(ignore_glob, ignore_links, links_expire):
+def check_links(ignore_glob, ignore_links, links_expire):  # noqa
     """Check URLs for HTML-containing files."""
     python = sys.executable.replace(os.sep, "/")
     cmd = f"{python} -m pytest --noconftest --check-links --check-links-cache "
@@ -29,7 +29,8 @@ def check_links(ignore_glob, ignore_links, links_expire):
         cmd += f' --ignore-glob "{spec}"'
         ignored.extend(glob(spec, recursive=True))
 
-    ignore_links = list(ignore_links) + [
+    ignore_links = [
+        *list(ignore_links),
         "https://github.com/.*/(pull|issues)/.*",
         "https://github.com/search?",
         "http://localhost.*",
@@ -61,14 +62,14 @@ def check_links(ignore_glob, ignore_links, links_expire):
             subprocess.check_output(file_cmd, shell=False)
         except Exception as e:
             # Return code 5 means no tests were run (no links found)
-            if e.returncode != 5:  # type:ignore[attr-defined]
+            if e.returncode != 5:  # type:ignore[attr-defined]  # noqa
                 try:
                     log(f"\n{f} (second attempt)...\n")
-                    subprocess.check_output(file_cmd + ["--lf"], shell=False)
+                    subprocess.check_output([*file_cmd, "--lf"], shell=False)
                 except subprocess.CalledProcessError as e:
                     log(e.output.decode("utf-8"))
                     fails += 1
-                    if fails == 3:
+                    if fails == 3:  # noqa
                         msg = "Found three failed links, bailing"
                         raise RuntimeError(msg) from e
     if fails:

.github/actions/pr-script/pr_script.py

@@ -36,7 +36,7 @@ def run(cmd, **kwargs):
         raise e
 
 
-def run_script():
+def run_script():  # noqa
     """Run a script on the target pull request URL"""
     # e.g. https://github.com/foo/bar/pull/81
 
@@ -51,7 +51,7 @@ def run_script():
     try:
         script = json.loads(script)
     except Exception:
-        pass
+        pass  # noqa
     if not isinstance(script, list):
         script = [script]
     if os.environ.get("PRE_COMMIT") == "true":

.pre-commit-config.yaml

@@ -35,7 +35,7 @@ repos:
       - id: black
 
   - repo: https://github.com/charliermarsh/ruff-pre-commit
-    rev: v0.0.206
+    rev: v0.0.237
     hooks:
       - id: ruff
         args: ["--fix"]

pyproject.toml

@@ -30,7 +30,7 @@ dependencies = ["mypy>=0.990"]
 test = "mypy --install-types --non-interactive {args:.}"
 
 [tool.hatch.envs.lint]
-dependencies = ["black==22.12.0", "mdformat>0.7", "ruff==0.0.206"]
+dependencies = ["black==22.12.0", "mdformat>0.7", "ruff==0.0.237"]
 detached = true
 [tool.hatch.envs.lint.scripts]
 style = [
@@ -75,42 +75,21 @@ target-version = ["py38"]
 target-version = "py38"
 line-length = 100
 select = [
-  "A", "B", "C", "E","EM", "F", "FBT", "I", "N", "Q", "RUF", "S", "T",
-  "UP", "W", "YTT",
+  "A", "B", "C", "DTZ", "E", "EM", "F", "FBT", "I", "ICN", "ISC", "N",
+  "PLC", "PLE", "PLR", "PLW", "Q", "RUF", "S", "SIM", "T", "TID", "UP",
+  "W", "YTT",
 ]
 ignore = [
-  # Allow non-abstract empty methods in abstract base classes
-  "B027",
-  # Ignore McCabe complexity
-  "C901",
-  # Allow boolean positional values in function calls, like `dict.get(... True)`
-  "FBT003",
-  # Use of `assert` detected
-  "S101",
-  # Line too long
-  "E501",
-  # Relative imports are banned
-  "TID252",
-  # Boolean ... in function definition
-  "FBT001", "FBT002",
-  # Module level import not at top of file
-  "E402",
-  # A001/A002/A003 .. is shadowing a python builtin
-  "A001", "A002", "A003",
-  # Possible hardcoded password
-  "S105", "S106",
   # Q000 Single quotes found but double quotes preferred
   "Q000",
-  # N806 Variable `B` in function should be lowercase
-  "N806",
+  # FBT001 Boolean positional arg in function definition
+  "FBT001", "FBT002", "FBT003",
+  # E501 Line too long (158 > 100 characters)
+  "E501",
+  # SIM105 Use `contextlib.suppress(...)`
+  "SIM105",
   # T201 `print` found
   "T201",
-  # N802 Function name `CreateWellKnownSid` should be lowercase
-  "N802", "N803",
-  # C408 Unnecessary `dict` call (rewrite as a literal)
-  "C408",
-  # N801 Class name `directional_link` should use CapWords convention
-  "N801",
 ]
 unfixable = [
   # Don't touch print statements