Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade actions #235

Merged
merged 5 commits into from
May 1, 2024
Merged

Upgrade actions #235

merged 5 commits into from
May 1, 2024

Conversation

fcollonval
Copy link
Member

@fcollonval fcollonval commented Apr 10, 2024

Upgrade actions to use NodeJS 20 and remove warning about node 16

Fixes jupyterlab/jupyterlab#15698

@fcollonval fcollonval marked this pull request as ready for review April 10, 2024 15:35
@krassowski
Copy link
Member

Thank you! It looks like the artifact names need to be adjusted to work with actions/upload-artifact@v4:

Error: Failed to CreateArtifact: Received non-retryable error: Failed request: (409) Conflict: an artifact with this name already exists on the workflow run

The upstream discussion is in actions/upload-artifact#478, it does not look like there are plans to change the new beahviour, so we need to adopt.

Copy link
Member

@jtpio jtpio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jtpio jtpio merged commit 08a5b0f into main May 1, 2024
26 checks passed
@jtpio jtpio deleted the fcollonval-patch-1 branch May 1, 2024 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Visual Regression Documentation tests action uses Node.js 16, which is deprecated
3 participants