Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable corepack if packageManager is defined #241

Merged
merged 3 commits into from
Jun 18, 2024
Merged

Conversation

fcollonval
Copy link
Member

@fcollonval fcollonval commented Jun 17, 2024

Fixes #240

packageManager has been added to package.json to test this.

@fcollonval fcollonval added the bug Something isn't working label Jun 17, 2024
@fcollonval
Copy link
Member Author

@krassowski @jtpio with the rolling of braces update by dependabot. I see lots of CI failing because the yarn.lock format gets updated. This is a side effect of the yarn version used by dependabot.

This did not happen on Lumino upgrade PR. I think because the packageManager is set in package.json. Therefore I would like to use that trick to prevent dependabot of running an unsupported version of yarn. Hence the need for this PR.

@fcollonval fcollonval marked this pull request as ready for review June 17, 2024 13:29
Copy link
Member

@jtpio jtpio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @fcollonval for looking into this!

Indeed, these failures have also been happening on other extension repos in general. Enabling corepack sounds like a good way to mitigate this (not sure there is another way).

@fcollonval fcollonval merged commit e255a87 into main Jun 18, 2024
26 checks passed
@fcollonval fcollonval deleted the fcollonval-patch-1 branch June 18, 2024 06:50
@fcollonval
Copy link
Member Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

base-setup fails if packageManager is set
2 participants