Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compress only new and modified versioned files #69

Merged
merged 2 commits into from
Mar 22, 2022

Conversation

fcollonval
Copy link
Member

In JupyterLab, the snapshots generation is split into two jobs. Triggering both broke the CI (see logs) because the compression tool was changing files not modified by playwright. This change the find command to a git list command to only touch modified versioned files.

The versioned list files will include deleted files but it will not happen in the workflow as playwright will only create or update snapshots.

@blink1073 blink1073 added the bug Something isn't working label Mar 15, 2022
Copy link
Contributor

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@blink1073 blink1073 merged commit e89a858 into jupyterlab:main Mar 22, 2022
@fcollonval fcollonval deleted the patch-1 branch March 22, 2022 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants