Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not install editable by default and dedupe constraints files #70

Merged
merged 1 commit into from
Mar 16, 2022

Conversation

blink1073
Copy link
Contributor

We shouldn't expect sdists to be installed in editable mode for downstream tests action. They should however still be unit-testable when installed to site-packages from a local test dir.

Also a minor cleanup to prevent duplicate entries in the constraints file in the minimum version action.

@blink1073 blink1073 added the bug Something isn't working label Mar 16, 2022
@blink1073 blink1073 merged commit aebcbd1 into jupyterlab:main Mar 16, 2022
@blink1073 blink1073 deleted the fix-upper-version-pin-handling branch March 16, 2022 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant