Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add default_url trait to NotebookApp #42

Merged
merged 1 commit into from
Jan 21, 2021
Merged

Add default_url trait to NotebookApp #42

merged 1 commit into from
Jan 21, 2021

Conversation

afshin
Copy link
Member

@afshin afshin commented Jan 21, 2021

default_url was missing from the NotebookApp and needs be reinstated for backwards compatibility. This also updates the shim layer to ignore default_url.

blink1073
blink1073 approved these changes Jan 21, 2021
View reviewed changes
Copy link
Contributor

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@blink1073 blink1073 merged commit c66e180 into jupyter:master Jan 21, 2021
@Zsailer Zsailer mentioned this pull request Jan 21, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blink1073 blink1073 blink1073 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@afshin @blink1073