Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REFACTOR]: [ZEN] Add amount conversion framework to Zen #6138

Open
2 tasks
ImSagnik007 opened this issue Sep 26, 2024 · 8 comments · May be fixed by #6373
Open
2 tasks

[REFACTOR]: [ZEN] Add amount conversion framework to Zen #6138

ImSagnik007 opened this issue Sep 26, 2024 · 8 comments · May be fixed by #6373
Assignees
Labels
A-connector-integration Area: Connector integration C-refactor Category: Refactor hacktoberfest Issues that are up for grabs for Hacktoberfest participants

Comments

@ImSagnik007
Copy link
Contributor

📝 Feature Description

Currently, amounts are represented as i64 values throughout the application. We want to introduce a Unit struct that explicitly states the denomination. A new type, MinorUnit, has been added to standardize the flow of amounts across the application. This type will now be used by all the connector flows.

Rather than handling conversions in each connector, we will centralize the conversion logic in one place within the core of the application.

🔨 Possible Implementation

  • For each connector, we need to create an amount conversion function. Connectors will specify the format they require, and the core framework will handle the conversion accordingly.
  • Connectors should invoke the convert function to receive the amount in their required format.
  • Refer to the connector documentation to determine the required amount format for each connector.
  • You can refer this PR for more context.

🔖 Note: All the changes needed should be contained within hyperswitch/crates/router/src/connector/ , crates/router/src/types/api.rs , crates/router/tests/connectors/

📦 Have you spent some time checking if this feature request has been raised before?

  • I checked and didn't find a similar issue

📦 Have you read the Contributing Guidelines?

✨ Are you willing to submit a PR?

Submission Process:

  • Ask the maintainers for assignment of the issue, you can request for assignment by commenting on the issue itself.
  • Once assigned, submit a pull request (PR).
  • Maintainers will review and provide feedback, if any.
  • Maintainers can unassign issues due to inactivity, read more here.

Refer here for Terms and conditions for the contest.

@ImSagnik007 ImSagnik007 added A-connector-integration Area: Connector integration C-refactor Category: Refactor hacktoberfest Issues that are up for grabs for Hacktoberfest participants labels Sep 26, 2024
@ayan-joshi
Copy link
Contributor

Hey @ImSagnik007 , I would like to work on this connector issue

@SanchitMahajan236
Copy link

Please assign me this issue as I would love to work on this issue.

@gorakhnathy7
Copy link
Collaborator

Hey @ayan-joshi i see you are already working on another issue, thus assigning this to @SanchitMahajan236

@gorakhnathy7
Copy link
Collaborator

Hey @SanchitMahajan236 ,

Quick check-in on the status of this issue. If you have any questions or need assistance, feel free to reach out in the community.

@SanchitMahajan236
Copy link

Hi @gorakhnathy7 , I am currently working on the issue.

@swangi-kumari
Copy link
Contributor

Hi @SanchitMahajan236 ,
Are you still working on this issue?
Please let us know if you need any help

@hex1c
Copy link

hex1c commented Oct 18, 2024

Hi @swangi-kumari if the issue is up for grabs, please assign it to me.I would like to work on it.

@SanchitMahajan236
Copy link

Hi @swangi-kumari , I'm still working on the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-connector-integration Area: Connector integration C-refactor Category: Refactor hacktoberfest Issues that are up for grabs for Hacktoberfest participants
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants