-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REFACTOR]: [ZEN] Add amount conversion framework to Zen #6138
Comments
Hey @ImSagnik007 , I would like to work on this connector issue |
Please assign me this issue as I would love to work on this issue. |
Hey @ayan-joshi i see you are already working on another issue, thus assigning this to @SanchitMahajan236 |
Hey @SanchitMahajan236 , Quick check-in on the status of this issue. If you have any questions or need assistance, feel free to reach out in the community. |
Hi @gorakhnathy7 , I am currently working on the issue. |
Hi @SanchitMahajan236 , |
Hi @swangi-kumari if the issue is up for grabs, please assign it to me.I would like to work on it. |
Hi @swangi-kumari , I'm still working on the issue. |
📝 Feature Description
Currently, amounts are represented as
i64
values throughout the application. We want to introduce aUnit
struct that explicitly states the denomination. A new type,MinorUnit
, has been added to standardize the flow of amounts across the application. This type will now be used by all the connector flows.Rather than handling conversions in each connector, we will centralize the conversion logic in one place within the core of the application.
🔨 Possible Implementation
convert
function to receive the amount in their required format.🔖 Note: All the changes needed should be contained within
hyperswitch/crates/router/src/connector/
,crates/router/src/types/api.rs
,crates/router/tests/connectors/
📦 Have you spent some time checking if this feature request has been raised before?
📦 Have you read the Contributing Guidelines?
✨ Are you willing to submit a PR?
Submission Process:
Refer here for Terms and conditions for the contest.
The text was updated successfully, but these errors were encountered: