Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(connector): Add amount conversion framework to Zen #6373

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

refactor(connector): Add amount conversion framework to Zen #6373

wants to merge 1 commit into from

Conversation

SanchitMahajan236
Copy link

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

This PR does amount conversion changes for Zen Connector and it accepts the amount in MinorUnit

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

Fixes #6138

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible

@semanticdiff-com SemanticDiff.com
Copy link

semanticdiff-com bot commented Oct 20, 2024 •
edited
Loading

Review changes with SemanticDiff.

Analyzed 4 of 4 files.

Overall, the semantic diff is 30% smaller than the GitHub diff.

Filename Status
✔️ crates/router/tests/connectors/zen.rs 44.78% smaller
✔️ crates/router/src/types/api.rs 78.19% smaller
✔️ crates/router/src/connector/zen.rs 25.99% smaller
✔️ crates/router/src/connector/zen/transformers.rs 37.73% smaller

@gorakhnathy7 gorakhnathy7 added the hacktoberfest Issues that are up for grabs for Hacktoberfest participants label Oct 21, 2024
@swangi-kumari swangi-kumari added A-connector-integration Area: Connector integration C-refactor Category: Refactor labels Oct 22, 2024
deepanshu-iiitu
deepanshu-iiitu requested changes Oct 24, 2024
View reviewed changes
crates/router/src/connector/zen.rs
use std::fmt::Debug;

use common_utils::{crypto, ext_traits::ByteSliceExt, request::RequestContent};
use common_utils::{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SanchitMahajan236 Please resolve the merge conflicts

@gorakhnathy7 gorakhnathy7 added the hacktoberfest-accepted Pull requests accepted as Hacktoberfest contributions label Oct 31, 2024
@gorakhnathy7
Copy link
Collaborator

Hey @SanchitMahajan236
Kindly look into the suggestions, and make the changes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deepanshu-iiitu deepanshu-iiitu deepanshu-iiitu requested changes

@swangi-kumari swangi-kumari Awaiting requested review from swangi-kumari

@NishantJoshi00 NishantJoshi00 Awaiting requested review from NishantJoshi00

Requested changes must be addressed to merge this pull request.

Assignees

@SanchitMahajan236 SanchitMahajan236

Labels
A-connector-integration Area: Connector integration C-refactor Category: Refactor hacktoberfest Issues that are up for grabs for Hacktoberfest participants hacktoberfest-accepted Pull requests accepted as Hacktoberfest contributions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[REFACTOR]: [ZEN] Add amount conversion framework to Zen
4 participants
@SanchitMahajan236 @gorakhnathy7 @deepanshu-iiitu @swangi-kumari