-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(api_models): add api_models for external 3ds authentication flow #3858
Merged
Gnanasundari24
merged 18 commits into
main
from
api_models_changes_for_external_authentication
Mar 5, 2024
Merged
feat(api_models): add api_models for external 3ds authentication flow #3858
Gnanasundari24
merged 18 commits into
main
from
api_models_changes_for_external_authentication
Mar 5, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sai-harsha-vardhan
added
A-core
Area: Core flows
C-feature
Category: Feature request or enhancement
labels
Feb 27, 2024
…ub.com:juspay/hyperswitch into api_models_changes_for_external_authentication
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than that, looks good to me!
SanchithHegde
added
M-api-contract-changes
Metadata: This PR involves API contract changes
S-waiting-on-review
Status: This PR has been implemented and needs to be reviewed
labels
Feb 28, 2024
ivor11
previously approved these changes
Mar 4, 2024
SanchithHegde
approved these changes
Mar 4, 2024
Narayanbhat166
approved these changes
Mar 5, 2024
ivor11
approved these changes
Mar 5, 2024
Gnanasundari24
deleted the
api_models_changes_for_external_authentication
branch
March 5, 2024 08:12
SanchithHegde
removed
the
S-waiting-on-review
Status: This PR has been implemented and needs to be reviewed
label
Mar 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-core
Area: Core flows
C-feature
Category: Feature request or enhancement
M-api-contract-changes
Metadata: This PR involves API contract changes
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
add api_models for external 3ds authentication flow
Hyperswitch currently uses the "Processor driven approach" for 3DS and is now looking to move towards "Third Party 3DS provider approach" - Using a specialized 3DS provider for checking card enrollment and 3DS authentication
Eg: Cardinal, Netcetra
The 3DS authentication can be done once and the authentication response that we get can be sent to any processor to authorize the payment.
API contract changes
Business profile API
Payments API
Request
"request_external_three_ds_authentication": true / false
Response
Authentication API
Request
Response
Additional Changes
Motivation and Context
How did you test it?
Compiler guided and Sanity testing to make sure it's backward compatible
This PR cannot be tested until core changes are done.
Checklist
cargo +nightly fmt --all
cargo clippy