feat(connector): add threedsecureio three_ds authentication connector #4004
Conversation
…odules-for-external-authn
…odules-for-external-authn
…pis-for-external-authn
sai-harsha-vardhan
added
A-connector-integration
| ) -> CustomResult<RequestContent, errors::ConnectorError> { | ||
| let connector_router_data = threedsecureio::ThreedsecureioRouterData::try_from(( | ||
| &self.get_currency_unit(), | ||
| req.request |
There was a problem hiding this comment.
When will Authentication flow comes into picture? After payment create or before?
If we call this flow after payments create then why amount and currency has to be option?
There was a problem hiding this comment.
This would be the common flow for both payment and non-payment authentication (payment_method authentication). payment_method authentication is yet to be implemented, which doesn't have amount and currency in the authentication flow
| ))?; | ||
| let req_obj = | ||
| threedsecureio::ThreedsecureioAuthenticationRequest::try_from(&connector_router_data); | ||
| println!("req_obj authn {:?}", req_obj); |
There was a problem hiding this comment.
Please remove print statements
| .parse_struct("ThreedsecureioAuthenticationResponse") | ||
| .change_context(errors::ConnectorError::ResponseDeserializationFailed)?; | ||
| event_builder.map(|i| i.set_response_body(&response)); | ||
| types::RouterData::try_from(types::ResponseRouterData { |
There was a problem hiding this comment.
add logger for response
| .threeds_server_transaction_id | ||
| .clone(), | ||
| }; | ||
| println!("req_obj post-authn {:?}", req_obj); |
| .response | ||
| .parse_struct("threedsecureio ThreedsecureioPreAuthenticationResponse") | ||
| .change_context(errors::ConnectorError::ResponseDeserializationFailed)?; | ||
| event_builder.map(|i| i.set_response_body(&response)); |
There was a problem hiding this comment.
also add logger for response
| }, | ||
| )?; | ||
| let billing_state = billing_address.clone().to_state_code()?; | ||
| let billing_country = isocountry::CountryCode::for_alpha2( |
There was a problem hiding this comment.
why do we need this conversion?
There was a problem hiding this comment.
we need to get the numeric_id of the country (https://docs.rs/isocountry/latest/isocountry/numeric/index.html), that's the reason we are using isocountry
| .expose() | ||
| .to_string(), | ||
| bill_addr_state: billing_state.peek().to_string(), | ||
| three_dsrequestor_authentication_ind: "01".to_string(), |
There was a problem hiding this comment.
value always going to be 01? For hard coded values like this please add comments about the significance.
| } | ||
| .to_string(), | ||
| browser_javascript_enabled: browser_details | ||
| .clone() |
There was a problem hiding this comment.
Avoid repeated clone of browser_details instead clone the respective values
| .to_string(), | ||
| purchase_date: date_time::DateTime::<date_time::YYYYMMDDHHmmss>::from(date_time::now()) | ||
| .to_string(), | ||
| sdk_app_id: sdk_information.clone().map(|sdk_info| sdk_info.sdk_app_id), |
There was a problem hiding this comment.
Avoid repeated clone of sdk_information instead clone the respective values
| @@ -120,6 +120,8 @@ openapi = { version = "0.1.0", path = "../openapi", optional = true } | |||
| erased-serde = "0.3.31" | |||
| quick-xml = { version = "0.31.0", features = ["serialize"] } | |||
| rdkafka = "0.36.0" | |||
| isocountry = "0.3.2" | |||
There was a problem hiding this comment.
This is not necessary, As we are already using iso codes in our enum
There was a problem hiding this comment.
this is required to get numeric_id of the country
| pub three_dscomp_ind: ThreeDSecureIoThreeDsCompletionIndicator, | ||
| pub three_dsrequestor_url: String, | ||
| pub acquirer_bin: String, | ||
| pub acquirer_merchant_id: String, |
There was a problem hiding this comment.
Please mask the necessary PII information
There was a problem hiding this comment.
this is not pii
There was a problem hiding this comment.
Please recheck all the fields and mask the necessary
| pub device_channel: String, | ||
| pub browser_javascript_enabled: Option<bool>, | ||
| pub browser_accept_header: Option<String>, | ||
| pub browser_ip: Option<String>, |
There was a problem hiding this comment.
Use type Secret<String, IpAddress>
|
|
||
| #[derive(Debug, Serialize, Deserialize)] | ||
| pub struct ThreeDSecureIoMetaData { | ||
| pub mcc: String, |
There was a problem hiding this comment.
Mask the necessary fields
Gnanasundari24
dismissed
ArjunKarthik’s stale review
The base branch was changed.
SanchithHegde
removed
the
S-waiting-on-review
Type of Change
Description
add threedsecureio three_ds authentication connector
Additional Changes
Motivation and Context
How did you test it?
Compiler guided and payments sanity testing
Checklist
cargo +nightly fmt --allcargo clippy