-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: create key in encryption service for merchant and user #4910
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dracarys18
added
A-core
Area: Core flows
S-waiting-on-review
Status: This PR has been implemented and needs to be reviewed
labels
Jun 7, 2024
dracarys18
changed the title
feat: create key in encryption service during merchant account and us…
feat: create key in encryption service for merchant and user
Jun 7, 2024
ArjunKarthik
previously approved these changes
Jun 7, 2024
…h into add_encryption_service
ArjunKarthik
previously approved these changes
Jul 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
ArjunKarthik
previously approved these changes
Jul 11, 2024
racnan
previously approved these changes
Jul 11, 2024
jarnura
previously approved these changes
Jul 11, 2024
lsampras
previously approved these changes
Jul 11, 2024
dracarys18
dismissed stale reviews from lsampras, jarnura, racnan, and ArjunKarthik
via
July 11, 2024 11:29
ad7a015
racnan
approved these changes
Jul 11, 2024
ArjunKarthik
approved these changes
Jul 11, 2024
lsampras
approved these changes
Jul 11, 2024
jarnura
approved these changes
Jul 11, 2024
pixincreate
removed
the
S-waiting-on-review
Status: This PR has been implemented and needs to be reviewed
label
Jul 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
This PR adds support to
Additional Changes
Motivation and Context
How did you test it?
Tests for Create a Merchant
/key/create
to Keymanager was succeeded.The response status of
keymanager_response
should be 200Create Key for User
/key/create
is successful in the logsChecklist
cargo +nightly fmt --all
cargo clippy