Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(blocklist): change primary key of blocklist table #5356

Merged
merged 9 commits into from
Jul 18, 2024

Conversation

prajjwalkumar17
Copy link
Contributor

@prajjwalkumar17 prajjwalkumar17 commented Jul 17, 2024

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Previously our Blocklist table had id as PKey.
Which needs to be changed to a composite Primary key as (merchant_id, fingerprint_id).

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

Required for V2

How did you test it?

Tested it by running the blocklist Apis, which is performing fine as the id field was no where being used.

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible

@prajjwalkumar17 prajjwalkumar17 requested review from a team as code owners July 17, 2024 18:41
@prajjwalkumar17 prajjwalkumar17 marked this pull request as draft July 17, 2024 18:41
@hyperswitch-bot hyperswitch-bot bot added the M-database-changes Metadata: This PR involves database schema changes label Jul 17, 2024
@prajjwalkumar17 prajjwalkumar17 changed the title Db/blocklist refactor Refactor(blocklist): reframe primary key of blocklist table Jul 17, 2024
@prajjwalkumar17 prajjwalkumar17 self-assigned this Jul 18, 2024
@prajjwalkumar17 prajjwalkumar17 added the C-refactor Category: Refactor label Jul 18, 2024
@prajjwalkumar17 prajjwalkumar17 added this to the July 2024 Release milestone Jul 18, 2024
@prajjwalkumar17 prajjwalkumar17 linked an issue Jul 18, 2024 that may be closed by this pull request
@prajjwalkumar17 prajjwalkumar17 marked this pull request as ready for review July 18, 2024 08:09
Narayanbhat166
Narayanbhat166 previously approved these changes Jul 18, 2024
@Narayanbhat166 Narayanbhat166 changed the title Refactor(blocklist): reframe primary key of blocklist table refactor(blocklist): change primary key of blocklist table Jul 18, 2024
@likhinbopanna likhinbopanna added this pull request to the merge queue Jul 18, 2024
Merged via the queue into main with commit 93047ae Jul 18, 2024
25 checks passed
@likhinbopanna likhinbopanna deleted the db/blocklist_refactor_id branch July 18, 2024 13:08
pixincreate added a commit that referenced this pull request Jul 19, 2024
* 'main' of github.com:juspay/hyperswitch: (26 commits)
  refactor(core): change primary keys in user, user_roles and roles tables (#5374)
  chore(version): 2024.07.19.1
  refactor(connector): make the `original_authorized_amount` optional for MITs with `connector_mandate_details` (#5311)
  feat(connector): Plaid connector Integration (#3952)
  feat: encryption service integration to support batch encryption and decryption (#5164)
  refactor(core): change primary key of refund table (#5367)
  chore(version): 2024.07.19.0
  chore(postman): update Postman collection files
  Docs: Updating Error codes for documentation purposes (#5314)
  fix(core): [payouts] failure of payout retrieve when token is expired (#5362)
  build: remove unused dependencies (#5343)
  refactor(blocklist): change primary key of blocklist table (#5356)
  chore: Increasing log coverage for payment method list (#5042)
  refactor(routing): Remove backwards compatibility for the routing crate (#3015)
  refactor(merchant_account): change primary key for merchant account (#5327)
  refactor(router): remove id dependency from merchant connector account, dispute and mandate (#5330)
  feat(connector): [Itau Bank] Template for payment flows (#5304)
  chore(version): 2024.07.18.0
  refactor(router): Remove the locker call in the psync flow (#5348)
  feat(router): Add support for passing the domain dynamically in the session call (#5347)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-refactor Category: Refactor M-database-changes Metadata: This PR involves database schema changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

refactor: reframe blocklist primary key for v2
4 participants