Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(custom-webpack): export common #793

Merged
merged 2 commits into from
Jul 13, 2020
Merged

Conversation

IKatsuba
Copy link
Contributor

@IKatsuba IKatsuba commented Jul 6, 2020

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[x] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

I need to use only the factory for modification of webpack configuration. But the factory is not exported.

Issue Number: N/A

What is the new behavior?

The factory is exported

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@just-jeb
Copy link
Owner

just-jeb commented Jul 12, 2020

Hi @IKatsuba. Would you mind elaborating on your use case? Everything that is exported is part of the public API and should be documented. How do you plan to use it?

@IKatsuba
Copy link
Contributor Author

Hi @just-jeb. I am creating a builder with built-in index.html transform factories and really want to reuse webpack configuration transform factory from your package

@just-jeb
Copy link
Owner

Ok. For now I'll merge it as is but maybe it's worth externalizing all the core functionality into a separate package, WDYT?

@just-jeb just-jeb merged commit 1cb73d4 into just-jeb:master Jul 13, 2020
@IKatsuba
Copy link
Contributor Author

That would be very useful!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants