Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(webpack5): simplify dependencies resolution when opt-in #853

Closed

Conversation

ydmitry
Copy link

@ydmitry ydmitry commented Nov 8, 2020

Should help with #841 , so to opt-in to webpack 5 need to write only resolution for webpack 5

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@ydmitry ydmitry changed the title feat(webpack5): simplify dependencies resolution when opt-in to we feat(webpack5): simplify dependencies resolution when opt-in Nov 8, 2020
@just-jeb
Copy link
Owner

just-jeb commented Nov 19, 2020

Hmm we actually can't do that, because builders work with specific version of Angular and major version can break builder's behavior.
You can see for example which changes were introduced in Angular 11 update (hint: some of them are breaking changes) #874.
But I guess #874 solves the problem right? Can this PR be closed then?

@ydmitry ydmitry closed this Nov 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants