-
-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to angular 11 #874
Merged
Merged
Update to angular 11 #874
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
b2b5327
chore(deps): bump angular-devkit from 10 to 11
jsone-studios 1b87cfd
chore(deps)!: update examples to angular 11
jsone-studios 841cd14
chore(deps): bump jest-preset-angular
jsone-studios df62efc
docs: update README.md and MIGRAION.md
jsone-studios e973739
Update MIGRATION.MD
just-jeb File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
55 changes: 33 additions & 22 deletions
55
packages/custom-webpack/examples/full-cycle-app/src/app/app.component.spec.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,25 +1,36 @@ | ||
| import { TestBed, async } from '@angular/core/testing'; | ||
| import { TestBed, waitForAsync } from '@angular/core/testing'; | ||
| import { AppComponent } from './app.component'; | ||
| describe('AppComponent', () => { | ||
| beforeEach(async(() => { | ||
| TestBed.configureTestingModule({ | ||
| declarations: [AppComponent], | ||
| }).compileComponents(); | ||
| })); | ||
| it('should create the app', async(() => { | ||
| const fixture = TestBed.createComponent(AppComponent); | ||
| const app = fixture.debugElement.componentInstance; | ||
| expect(app).toBeTruthy(); | ||
| })); | ||
| it(`should have as title 'app'`, async(() => { | ||
| const fixture = TestBed.createComponent(AppComponent); | ||
| const app = fixture.debugElement.componentInstance; | ||
| expect(app.title).toEqual('full-cycle-app'); | ||
| })); | ||
| it('should render title in a h1 tag', async(() => { | ||
| const fixture = TestBed.createComponent(AppComponent); | ||
| fixture.detectChanges(); | ||
| const compiled = fixture.debugElement.nativeElement; | ||
| expect(compiled.querySelector('h1').textContent).toContain('Welcome to full-cycle-app!'); | ||
| })); | ||
| beforeEach( | ||
| waitForAsync(() => { | ||
| TestBed.configureTestingModule({ | ||
| declarations: [AppComponent], | ||
| }).compileComponents(); | ||
| }) | ||
| ); | ||
| it( | ||
| 'should create the app', | ||
| waitForAsync(() => { | ||
| const fixture = TestBed.createComponent(AppComponent); | ||
| const app = fixture.debugElement.componentInstance; | ||
| expect(app).toBeTruthy(); | ||
| }) | ||
| ); | ||
| it( | ||
| `should have as title 'app'`, | ||
| waitForAsync(() => { | ||
| const fixture = TestBed.createComponent(AppComponent); | ||
| const app = fixture.debugElement.componentInstance; | ||
| expect(app.title).toEqual('full-cycle-app'); | ||
| }) | ||
| ); | ||
| it( | ||
| 'should render title in a h1 tag', | ||
| waitForAsync(() => { | ||
| const fixture = TestBed.createComponent(AppComponent); | ||
| fixture.detectChanges(); | ||
| const compiled = fixture.debugElement.nativeElement; | ||
| expect(compiled.querySelector('h1').textContent).toContain('Welcome to full-cycle-app!'); | ||
| }) | ||
| ); | ||
| }); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
14 changes: 8 additions & 6 deletions
14
packages/custom-webpack/examples/sanity-app/src/app/app.component.spec.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 changes: 3 additions & 0 deletions
3
packages/jest/examples/multiple-apps/projects/my-shared-library/tsconfig.lib.prod.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why the
ngccpostinstall has been removed?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
postinstall is no longer recommended (it it faster to process libs that application will import than whole node_modules)
https://github.com/angular/angular/blob/master/CHANGELOG.md#910-2020-03-25
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ngccproduced a warning because of a "solution-style" tsconfig. When I tried to resolve the warning, I found the PR angular/angular#38003 introducing it and found this comment of an angular team member:I tried without the
ngccpostinstall and it did work without any issues. Therefore I have removed it.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting... The
ngcchere was rather for example than because of actual need. The thing is that Angular CLI builders (including Karma) use Angular tool chain on order to prepare files for tests, while Jest doesn't. This means that there is no way to runngccprogrammatically only on libraries that you need (becausets-jestdoesn't utilize Angular tool chain).Well, there is a way but it's very complicated and requires major rewrite of
ts-jest.Hence, if your app uses incompatible libs (that were not compiled with Ivy) you have to run
ngccmanually on these libs.I guess we can remove it from the examples and add to the docs, this should be enough.