Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update webpack merge #907

Merged
merged 10 commits into from
Dec 13, 2020
Merged

Update webpack merge #907

merged 10 commits into from
Dec 13, 2020

Conversation

just-jeb
Copy link
Owner

@just-jeb just-jeb commented Dec 13, 2020

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

  • Custom webpack builder uses webpack-merge@4, with smart strategy as a default.
  • The configuration field is called mergeStrategies

Issue Number: N/A

What is the new behavior?

  • Custom webpack builder uses webpack-merge@5, mergeWithRules method, with some predefined configuration as a default. Tried to keep it as close as possible to the smart strategy.
  • The configuration field is called mergeRules

Does this PR introduce a breaking change?

[x] Yes
[ ] No

The migration path is added to MIGRATION.md

Copy link

@autoapproval autoapproval bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved 👍

@just-jeb just-jeb merged commit 421d867 into master Dec 13, 2020
@just-jeb just-jeb deleted the update-webpack-merge branch December 13, 2020 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant