-
-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: use jest-preset-angular@9 #913
Merged
Merged
Changes from 2 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
ccbb471
feat(jest): use latest jest-preset-angular
b9f96bb
docs(jest): update the migration guide
443ae07
ci: use node 12.13
just-jeb 197f17b
Update package.json
just-jeb 585c7d3
fix(jest): import preset properly according to breaking change
just-jeb 0630d21
fix(jest): depend on v27 according to breaking change
just-jeb b39d36a
fix(jest): update node engine version
just-jeb 49f3035
Merge branch 'master' into latest-jest-preset
92dc7cd
chore: update jest version
just-jeb 8a1429a
chore: update jest version
just-jeb c9a2d8b
Update package.json
just-jeb 705a87b
Update package.json
just-jeb ece3f6c
docs: update migration guide
just-jeb 1caed5e
docs(jest): remove ngcc mention
just-jeb File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi,
jest-preset-angular
have reverted that change and will still usets-jest
forisolatedModules: false
. WithisolatedModules: true
, codes will be transformed viajest-preset-angular
instead ofts-jest
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ahnpnl thanks for noticing. Anyways this update will have to wait until they release stable version
9
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm still waiting for Jest 27. Once Jest 27 is out, version 9 will follow too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
9.0.0 was out.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we try to update to the latest version now and also update the
MIGRATION.MD
? [email protected]There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@just-jeb any update on this? still have to use plain jest to run angular tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've pushed changes according to the breaking changes from the CHANGELOG, if it passes I'll update the migration guide and merge.
However, if there are issues I won't be able to investigate properly since I'm away from computer until June 20th.
You're welcome to help though if there are issues with the build/tests - while I can't investigate I can release a new version from my phone 😄