Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #1019

Merged
merged 3 commits into from
Nov 5, 2022
Merged

Update README.md #1019

merged 3 commits into from
Nov 5, 2022

Conversation

pdmosses
Copy link
Contributor

Major update:

  • Refer to just-the-docs-template for getting started.
  • Avoid duplication of details provided in the template README.
  • Distinguish between theme users and theme developers.
  • Augment the items for submitting code changes
  • Make the marked-up text easier to read and edit by using short-cut link references.

See also the closely-related PR #1018.

Major update:

- Refer to `just-the-docs-template` for getting started.
- Avoid duplication of details provided in the template README.
- Distinguish between theme users and theme developers.
- Augment the items for submitting code changes
- Make the marked-up text easier to read and edit by using short-cut link references.

(Not yet checked on GitHub.)
Copy link
Member

@mattxwang mattxwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Appreciate you calling out that you don't need to fork the repo, I think that's one of the more confusing approaches.

Before I merge - I do think it would be good to still have docs for using JTD as a gem in the README - this is standard for any gem. What are your thoughts?

@pdmosses
Copy link
Contributor Author

Before I merge - I do think it would be good to still have docs for using JTD as a gem in the README - this is standard for any gem. What are your thoughts?

I'm not familiar with the broader Ruby/gem ecosystem. I was thinking that anyone who wanted to start using the theme would be happy to use the template to create a fresh repo, instead of needing to set up Gemfile and _config.yml themselves. If they want to add a website using the theme to an existing repo, they could copy the contents of the new repo to their docs folder (then delete the repo created by the template). I hadn't imagined other ways of using the theme gem.

Anyway, I think you're suggesting retaining the following part of the original README.md:

Alternatively you can install it as a Ruby Gem.

Add this line to your Jekyll site's Gemfile:

gem "just-the-docs"

And add this line to your Jekyll site's _config.yml:

theme: just-the-docs

And then execute:

$ bundle

Or install it yourself as:

$ gem install just-the-docs

Alternatively, you can run it inside Docker while developing your site

$ docker-compose up

Provided that it comes after the suggestion to use the template, I don't mind adding that back in. Should I do it in my PR branch before you merge? You're of course welcome to edit my branch if that's easier for you.

@pdmosses
Copy link
Contributor Author

pdmosses commented Nov 2, 2022

Before I merge - I do think it would be good to still have docs for using JTD as a gem in the README - this is standard for any gem. What are your thoughts?

I've now restored the original section on using RubyGems.

Copy link
Member

@mattxwang mattxwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, sorry - personal stuff ended up getting in the way of things. Meant to respond earlier that I would be fine swinging either way, but I'm also happy with what's on the branch now; thanks for being proactive with both this and responding to other issues and discussions. I know I keep on saying this, but I actually should be able to write some sort of migration guide and wrap up actionables this weekend!

@mattxwang mattxwang merged commit a1bac2d into just-the-docs:main Nov 5, 2022
@pdmosses pdmosses deleted the update-readme branch November 27, 2022 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants