-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update README.md #1019
Update README.md #1019
Conversation
Major update: - Refer to `just-the-docs-template` for getting started. - Avoid duplication of details provided in the template README. - Distinguish between theme users and theme developers. - Augment the items for submitting code changes - Make the marked-up text easier to read and edit by using short-cut link references. (Not yet checked on GitHub.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Appreciate you calling out that you don't need to fork the repo, I think that's one of the more confusing approaches.
Before I merge - I do think it would be good to still have docs for using JTD as a gem in the README - this is standard for any gem. What are your thoughts?
I'm not familiar with the broader Ruby/gem ecosystem. I was thinking that anyone who wanted to start using the theme would be happy to use the template to create a fresh repo, instead of needing to set up Anyway, I think you're suggesting retaining the following part of the original
Provided that it comes after the suggestion to use the template, I don't mind adding that back in. Should I do it in my PR branch before you merge? You're of course welcome to edit my branch if that's easier for you. |
I've now restored the original section on using RubyGems. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, sorry - personal stuff ended up getting in the way of things. Meant to respond earlier that I would be fine swinging either way, but I'm also happy with what's on the branch now; thanks for being proactive with both this and responding to other issues and discussions. I know I keep on saying this, but I actually should be able to write some sort of migration guide and wrap up actionables this weekend!
Major update:
just-the-docs-template
for getting started.See also the closely-related PR #1018.