Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Mpv audio tracks and subtitles #303

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix: Mpv audio tracks and subtitles #303

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2098851
Fix(mpv): Escape separators on audio tracks and subtitles
h-banii Feb 22, 2024
f4a8e3d
Fix(mpv): Edge case when subtitles and audio_tracks are empty
h-banii Feb 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions animdl/core/cli/helpers/players/mpv.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,12 @@ def play(
):
args = (self.executable, *self.args, stream_url)

if audio_tracks is not None:
if audio_tracks:
audio_tracks = map(
lambda audio_track: audio_track.replace(self.path_joiner, f"\{self.path_joiner}"),
audio_tracks
)

args += (
f"{self.opts_spec['audios']}={self.path_joiner.join(audio_tracks)}",
)
Expand All @@ -55,7 +60,12 @@ def play(
f"{self.opts_spec['media-title']}={title}",
)

if subtitles is not None:
if subtitles:
subtitles = map(
lambda subtitle: subtitle.replace(self.path_joiner, f"\{self.path_joiner}"),
subtitles
)

args += (
f"{self.opts_spec['subtitles']}={self.path_joiner.join(subtitles)}",
)
Expand Down