Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various minor improvements #29

Merged

Conversation

lgoldstein
Copy link

  • Promote methods visibility - for easier use by code that wants to use the same parameters as the encryptor/decryptor
  • Expose wrapSource/targetStream for code that needs to encrypt streams instead of files - to allow callers to optimize their streams accordingly
  • Use try-with-resource for clearer code
  • Use absolute paths to ensure file not encrypted/decrypted onto itself

@justinludwig justinludwig merged commit 8d370d6 into justinludwig:master Dec 24, 2020
@justinludwig
Copy link
Owner

Nice! I merged, and also added a quick javadoc one-liner to the newly-public methods that didn't have any javadocs yet.

@lgoldstein
Copy link
Author

Great thanks.

@lgoldstein lgoldstein deleted the promote-method-visibility branch December 24, 2020 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants