-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(playground): Added a small playground based on systemjs #146
Conversation
@izifortune — This is awesome, thank you! Would you be able to make the following changes:
Currently, Can you also rebase on the latest version of this generator? Then we can merge your changes. Thanks again, wonderful job!! 🏆 |
This feature enable to visualize changes of your module without the needs to link the module to another app.
566ab04
to
692433e
Compare
@jvandemo I've managed to contain everything inside playground but there is a catch: Currently lite-server will server everything from the root folder of the package, moving to have a baseDir of playground means that the The only way that i've found to make this work is to use symlinks inside the playground. |
@izifortune — What if you run lite-server in the root and navigate your browser to Thanks again for your great work! |
Yes that will work but i'm not in a position to say which one is better. Your call 😄 |
@jvandemo rebased, fixed the linting errors and also managed to run from the root but serving only /playground/index.html as default. This is done in the So no symlinks but at the same time |
Any update on this ?! |
@izifortune — Awesome work, thank you so much! 👍 🏆 |
While the library works well even exported and installed, the Playground cannot fin my dependency: |
@pietromarrone -| I had the very same issue. If you look at the file path you are importing from it is probably missing the file extension, which we typically leave off as the loader will add it. If you notice your ng2-webstorage has no file extension. What worked for me was to add this to the systemjs.config.js packages: { NOTE: All I added to packages: {} was ".": {defaultExtension: "js"}, After I added this, the playground would load my files. The other fix is to just add the extension yourself to the file paths in your modules. I noted that worked for me as well. As in import { thingComponent } from './components/thing.component.js' NOTE: It will be a .js file by the time it imports even though it may begin a '.ts' file. I tried "playground" but only "." has worked so far. Then I just added an NPM Link to the real package guts as mentioned above. Everything is working now for developing locally for me. |
@izifortune — Would you be able to have a look at this? Thanks in advance! |
Change has been implemented and released as v12.2.0. Thank you for reporting, much appreciated! 👍 |
This feature enable to visualize changes of your
module without the needs to link the module to another
app.