Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update rollup config for newer version reqs #270

Merged
merged 1 commit into from
Mar 16, 2018
Merged

update rollup config for newer version reqs #270

merged 1 commit into from
Mar 16, 2018

Conversation

zgabievi
Copy link
Contributor

The following options have been renamed — please update your config: name -> output.name, globals -> output.globals, format -> output.format, exports -> output.exports

The following options have been renamed — please update your config: name -> output.name, globals -> output.globals, format -> output.format, exports -> output.exports
@jvandemo
Copy link
Owner

@zgabievi — Thank you for your contribution.

Does the change require a specific version of rollup? If so, is an update package.json needed to ensure the config does not break for people with older versions of rollup?

Thanks in advance!

@zgabievi
Copy link
Contributor Author

I have not tested it but I’m pretty sure it will break on old versions. But what’s the difference if its broken on newer version. I think it’s better to keep config up to date. But you are boss. You should decide ;)

@jvandemo
Copy link
Owner

jvandemo commented Feb 4, 2018

@zgabievi Since which version of rollup has the config format changed to the format in your PR? Then we can update package.json accordingly. Thanks in advance!

@zgabievi
Copy link
Contributor Author

zgabievi commented Feb 5, 2018

Since 0.48.0. Check the gist for example of options format: https://gist.github.com/Rich-Harris/d472c50732dab03efeb37472b08a3f32

@jvandemo
Copy link
Owner

jvandemo commented Mar 16, 2018

@zgabievi — Thank you for your contribution! 🏆
@izifortune — Thank you for your review 👍

@jvandemo jvandemo merged commit 0052c06 into jvandemo:master Mar 16, 2018
@jvandemo
Copy link
Owner

Changes have been released as v12.3.0 👍

@zgabievi
Copy link
Contributor Author

@jvandemo You are welcome 👍

@zgabievi zgabievi deleted the patch-1 branch March 16, 2018 06:12
@jvandemo
Copy link
Owner

@zgabievi — 🏆 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants