Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Function to retrieve isOpen #52

Merged
merged 1 commit into from
May 5, 2015
Merged

Conversation

timonsku
Copy link
Contributor

@timonsku timonsku commented May 5, 2015

I updated my local version and ran into the issue that isOpen is now private. So I added a function to retrieve it.

@jvcleave
Copy link
Owner

jvcleave commented May 5, 2015

Cool - I think I changed it as setup returns a bool you can track yourself but I can see it being useful to get it from the class.

I'll go ahead and merge it but eventually change isOpen to didOpen make getIsOpen() isOpen()

jvcleave added a commit that referenced this pull request May 5, 2015
Function to retrieve isOpen
@jvcleave jvcleave merged commit f6245b9 into jvcleave:master May 5, 2015
@timonsku
Copy link
Contributor Author

timonsku commented May 5, 2015

Yes that sounds good! I didnt want to change the variable name just now.

Having setup return it is helpful aswell. I use it when I close the player on user input and need to know when it actually closed and I can re-use the player object. In that case getting the bool is usefull.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants