♻️ change nan default handling behavior to SkipNa #28
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change default behavior for nan-handling (i.e.,
argminmax
) to ignore (or skip) nans instead of returning (the first) nan indexReasons why argminmax default will ignore nans:↔️ numpy default (which returns nan index)
✔️ no performance regressions for default implementation
✔️ backwards compatible
🤝 same as default pandas & polars behavior
❗
Other contributions of this PR:
float_simd.rs
to more concrete names w.r.t. their nan handling behavior