Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow double update in scalar ignore nan implementation #40

Merged
merged 4 commits into from
Mar 5, 2023

Conversation

jvdd
Copy link
Owner

@jvdd jvdd commented Mar 5, 2023

Fixes a bug in SCALAR<FloatIgnoreNaN> when the first element in the array is NaN.

The code used an else-if for updating low / max - but this should be 2 seperate ifs to allow double update when the first non-NaN value is encountered.

@codspeed-hq
Copy link

codspeed-hq bot commented Mar 5, 2023

CodSpeed Performance Report

Merging #40 scalar_ignore_nan_bug (6ba2249) will not alter performances.

Summary

🔥 0 improvements
❌ 2 regressions
✅ 50 untouched benchmarks

🆕 0 new benchmarks
⁉️ 0 dropped benchmarks

Benchmarks breakdown

Benchmark main scalar_ignore_nan_bug Change
scalar_f32_argminmax_in 1.7 ms 1.9 ms -9.96%
scalar_f64_argminmax_in 1.9 ms 2.1 ms -9.02%

@jvdd jvdd merged commit 9493a89 into main Mar 5, 2023
@jvdd jvdd deleted the scalar_ignore_nan_bug branch March 26, 2023 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant