Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add number of failed states metric to comparative analysis board (Fixes #43) #69

Merged
merged 6 commits into from
Mar 29, 2024

Conversation

JoshDFitzgerald
Copy link
Collaborator

Will need to revisit since current solution is hacky. End goal is to change results.py to simply have failed state as a column value so I don't need to iterate through failed.txt for every run. Also, had to change around file path variables so i could access them later in the file but it looks real ugly and i'm sure there's a way to make it way cleaner

Copy link

codecov bot commented Mar 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.1%. Comparing base (cc79af3) to head (88081ec).

Additional details and impacted files
@@          Coverage Diff          @@
##            main     #69   +/-   ##
=====================================
  Coverage   93.1%   93.1%           
=====================================
  Files          7       7           
  Lines        308     308           
  Branches      50      50           
=====================================
  Hits         287     287           
  Misses        11      11           
  Partials      10      10           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

The deltas don't really make much sense in this context (especially once number of runs > 2). Reporting the number of failures is sufficient
@jvivian
Copy link
Owner

jvivian commented Mar 23, 2024

@JoshDFitzgerald Take a look at d2d077c if you want to see how I used a negate/return pattern to minimize conditional nesting.

I'll wait for an approval from @AaronCooke2718 or @JoshDFitzgerald before I merge.

cleaned up the function a bit
@jvivian jvivian changed the title added failed states Add number of failed states metric to comparative analysis board (Fixes #43) Mar 23, 2024
@jvivian
Copy link
Owner

jvivian commented Mar 23, 2024

Thanks for taking this on btw @JoshDFitzgerald !

@jvivian jvivian merged commit 131880c into main Mar 29, 2024
7 checks passed
@jvivian jvivian deleted the issue_43 branch March 29, 2024 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants