Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update action to use updated version of Node #25

Closed
ghost opened this issue Oct 11, 2022 · 3 comments · Fixed by #28
Closed

Update action to use updated version of Node #25

ghost opened this issue Oct 11, 2022 · 3 comments · Fixed by #28
Labels

Comments

@ghost
Copy link

ghost commented Oct 11, 2022

Seeing the following warning message when using this action:

Node.js 12 actions are deprecated. For more information see: https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/. Please update the following actions to use Node.js 16: jwalton/gh-find-current-pr

Looks like the version is set here: https://github.com/jwalton/gh-find-current-pr/blob/master/action.yml#L27

@jwalton
Copy link
Owner

jwalton commented Oct 11, 2022

Thanks for the heads up! I'll update this sometime this week. I've been wanting to migrate this to TypeScript too - see if I can do that at the same time.

@ghost
Copy link

ghost commented Oct 12, 2022

Hello, there appears to be another deprecation warning regarding set-output - which this action triggers 5x due to:

https://github.com/jwalton/gh-find-current-pr/blob/master/main.js#L21
https://github.com/jwalton/gh-find-current-pr/blob/master/main.js#L23
https://github.com/jwalton/gh-find-current-pr/blob/master/main.js#L25
https://github.com/jwalton/gh-find-current-pr/blob/master/main.js#L27
https://github.com/jwalton/gh-find-current-pr/blob/master/main.js#L28

Warning: The set-output command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

I believe this would be fixed if the @actions/core dependency is upgraded to 1.10.0, or using environment files

github-actions bot pushed a commit that referenced this issue Oct 13, 2022
## [1.3.1](v1.3.0...v1.3.1) (2022-10-13)

### Bug Fixes

* Small fix for multiple PRs. ([176ed1b](176ed1b)), closes [#18](#18)
* Upgrade to node 16, update deprecated dependencies. ([138dea2](138dea2)), closes [#25](#25)
@github-actions
Copy link

🎉 This issue has been resolved in version 1.3.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant