Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added filter for open PR #5

Merged
merged 1 commit into from
Feb 11, 2021
Merged

Added filter for open PR #5

merged 1 commit into from
Feb 11, 2021

Conversation

8BitJonny
Copy link
Contributor

@8BitJonny 8BitJonny commented Feb 19, 2020

Added filter for open PR

Simply just modifying the one line from:

const pr = result.data.length > 0 && result.data[0];

to

const pr = result.data.length > 0 && result.data.filter(el => el.state === 'open')[0];

You can see in my test PR that I created in my Fork and in the actions tab that it works as expected and the github action run triggered by merging the PR doesn't return any PR number anymore.

I don't know how active you still are with this repository so I would wait a bit and if I don't get a response for this PR I would switch in my company to use my Fork as a Github action. I'd love to still use yours as you are the original author of this repo and I want to give you this credit but I kinda want to switch fast to the new version since it currently makes our tests fail.

closes #2

@jwalton jwalton merged commit da4a054 into jwalton:master Feb 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make sure the returned PR is open
3 participants