Add support for building against Java 11 #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
eric-weaver
commented
Sep 14, 2020
•
eric-weaver
commented
- Adds a new maven profile that is automatically activated if current JAVA_HOME jdk is java 11
- Adds openjdk11 build to travis
- Moves all dependency versions to property variables
- Updates the maven-shade-plugin dependency
- Adds the maven-enforcer-plugin to set minimum maven version
- Removed cobertura plugin. Wasn't configured to run previously. It also receives a class not found issue on java 11
eric-weaver
force-pushed
the
upgrade-java11
branch
2 times, most recently
from
8253198
to
0a66877
Compare
eric-weaver
force-pushed
the
upgrade-java11
branch
from
0a66877
to
32ea223
Compare
eric-weaver
requested review from
arron-green and
moritastic
and removed request for
arron-green
arron-green
reviewed
Oct 9, 2020
pom.xml
Outdated
| <scope>test</scope> | ||
| </dependency> | ||
| <dependency> |
There was a problem hiding this comment.
did you mean to bring this one in? might want to move it bear the runtime dependencies. Currently it's listed organized with the test dependencies
There was a problem hiding this comment.
This is required for java 11
arron-green
reviewed
Oct 9, 2020
| </configuration> | ||
| </plugin> | ||
| <plugin> | ||
| <groupId>org.apache.maven.plugins</groupId> |
There was a problem hiding this comment.
👍 this could help with enforcing some of the transitive dependency issues this project currently has
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.