Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adds jcl slf4j bridge required for logback #70

Merged
merged 1 commit into from
Oct 9, 2020
Merged

adds jcl slf4j bridge required for logback #70

merged 1 commit into from
Oct 9, 2020

Conversation

arron-green
Copy link
Contributor

since amazon's s3 lib depends on java common logging the current version doesn't respect logback's appender format

adding this slf4j bridge dependency allows the logback logging configuration to take control over JCL logging

@eric-weaver eric-weaver added the hacktoberfest-accepted Accepted hacktoberfest contributions label Oct 9, 2020
@arron-green arron-green merged commit 5953497 into master Oct 9, 2020
@arron-green arron-green deleted the agreen-bridge-aws-java-commons-logging-dep branch October 9, 2020 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eric-weaver eric-weaver eric-weaver approved these changes

Assignees
No one assigned
Labels
hacktoberfest-accepted Accepted hacktoberfest contributions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arron-green @eric-weaver