[BIG-4969] Removing a bug in ByteArraySet chunk iteration #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qlecorre
force-pushed
the
qlecorre-BIG-4969-51
branch
5 times, most recently
from
860e663
to
e4162aa
Compare
qlecorre
changed the title
qlecorre
force-pushed
the
qlecorre-BIG-4969-51
branch
6 times, most recently
from
555a7a9
to
555ea71
Compare
BIG-4969
qlecorre
force-pushed
the
qlecorre-BIG-4969-51
branch
from
0b6eb54
to
e8e36ca
Compare
qlecorre
commented
Oct 29, 2020
qlecorre
changed the title
added 2 commits
October 29, 2020 14:36
eric-weaver
reviewed
Oct 29, 2020
eric-weaver
reviewed
Oct 29, 2020
arron-green
reviewed
Oct 29, 2020
src/test/java/com/jwplayer/southpaw/SouthpawByteArraySetEndToEndTest.java
Outdated
Show resolved
Hide resolved
added 6 commits
October 29, 2020 15:12
…er/southpaw into qlecorre-BIG-4969-51
…er/southpaw into qlecorre-BIG-4969-51
eric-weaver
reviewed
Nov 9, 2020
eric-weaver
reviewed
Nov 9, 2020
eric-weaver
reviewed
Nov 9, 2020
eric-weaver
reviewed
Nov 9, 2020
eric-weaver
reviewed
Nov 9, 2020
eric-weaver
reviewed
Nov 9, 2020
eric-weaver
reviewed
Nov 9, 2020
eric-weaver
reviewed
Nov 9, 2020
eric-weaver
reviewed
Nov 9, 2020
eric-weaver
reviewed
Nov 9, 2020
eric-weaver
reviewed
Nov 9, 2020
eric-weaver
reviewed
Nov 9, 2020
eric-weaver
reviewed
Nov 9, 2020
|
|
||
| List<ByteArray> vals = getRandomByteArrays(size); | ||
|
|
||
| for (ByteArray val: vals) { |
There was a problem hiding this comment.
Can be instantiated by the constructor rather than looping
There was a problem hiding this comment.
ByteArraySet cannot be instantiated with a List, but simplified with addAll
eric-weaver
reviewed
Nov 9, 2020
eric-weaver
reviewed
Nov 9, 2020
eric-weaver
reviewed
Nov 9, 2020
eric-weaver
approved these changes
Nov 17, 2020
moritastic
approved these changes
Nov 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GOAL:
This pull request fixes a bug in the way we iterate over
ByteArraySetchunks, which would cause data loss.The bug arises on serialization if the last value of one of the chunks was deleted. In this case, the iteration over chunks would terminate on that chunk, the ones after being lost. This is because we increment
currentOffsetwithout actually updatingcurrentChunk, hence causing the subsequenthasNext()to returnfalse.The
testEmptyLastValueChunkIteratorBug()test presents reproduction steps (in case you are interested).BUILDING BLOCKS:
Below are some branches and Docker images I created as par of the investigation:
Only Bytes:
Only Front Set:
Both Front Set and Bytes:
MANUAL DEBUGGING:
Use qlecorre-BIG-4969-51-local-debugging branch for debugging
BIG-4969