Refactor null checks with 'is not null' in JwtBuilder #484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great suggestion! I was a bit lazy to do this myself :) Do you mind making the change to all files across the repo? |
|
Ok I will try to do it |
|
@mmfazrin-phcc-gov ping please. your help would be appreciated! |
To better follow the naming convention and improve code readability, the null checks in JwtBuilder.cs have been updated from 'is object' to 'is not null'. The updated null checks include the variables '_algorithm', '_algFactory', '_validator', '_jsonSerializerFactory', '_urlEncoder', and '_jwt.Payload'.
The code has been revised to use the 'is not null' pattern for null checks throughout multiple files. This change enhances the code readability and uniformity, providing a more modern way to handle null checks.
Hi, Sorry totally forgot due to the December vacation, updated the code |
abatishchev
approved these changes
Jan 21, 2024
|
Awesome, thanks for the contribution!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To better follow the naming convention and improve code readability, the null checks in JwtBuilder.cs have been updated from
is objecttois not null.