-
Notifications
You must be signed in to change notification settings - Fork 462
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed referencing System.Text.Json when targeting modern .NET #497
Removed referencing System.Text.Json when targeting modern .NET #497
Conversation
Can you cite any docs which would confirm that STJ is available without referencing it? If it is then which version? How to update it in the future, e.g. in case of a security vulnerability? |
@abatishchev easiest way to confirm it is look in Visual Studio, and expand out the framework under dependencies and that will reveal what is included in the framework. In the case of security vulnerability this made even easier to manage as when the framework used to compile the application gets a new release of STJ (within the same major), the client applications automatically get provided this based on their framework. Hence less maintenance effort. |
Let me check with the .NET team :) I'll circle back. |
Spoke to the .NET team, was told this:
Thanks for educating me, I dind't know. Will re-review the PR and get it going soon. |
@thompson-tomo can you please check why the build fails? |
@abatishchev have tweaked the conditions which has resolved the build issue |
1281b9b
to
2684905
Compare
2684905
to
cfa2888
Compare
Awesome, thank you again, @thompson-tomo! |
Published all packages to NuGet.org as |
Description
Resolves #496.
This removes System.Text.Json as a dependency for dotnet 6 due to it being natively provided by the framework hence the explicit dependency is not need for that TFM.
Checklist
[ ] Tests added