Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Semantic versioning #37

Closed
pezra opened this issue May 6, 2014 · 4 comments
Closed

Semantic versioning #37

pezra opened this issue May 6, 2014 · 4 comments

Comments

@pezra
Copy link

pezra commented May 6, 2014

The last release included an incompatible change to JWT's interface which broke several of my projects. Any chance we could switch to semantic versioning so that consumers of this API don't unsuspectingly upgrade to incompatible versions?

@progrium
Copy link
Contributor

progrium commented May 6, 2014

Sounds good. Just requires me to pay more attention to PR before doing
releases. Ideas on process that can be automated?

On Tue, May 6, 2014 at 5:00 PM, Peter Williams [email protected]:

The last release included an incompatible change to JWT's interface which
broke several of my projects. Any chance we could switch to semantic
versioning http://semver.org/ so that consumers of this API don't
unsuspectingly upgrade to incompatible versions?


Reply to this email directly or view it on GitHubhttps://github.com//issues/37
.

Jeff Lindsay
http://progrium.com

@pezra
Copy link
Author

pezra commented May 7, 2014

Unfortunately, i have not found a good way to automate this. Sometimes an
"acceptance" test suite combined with CI can help. The idea being that if a
change to the library doesn't require a matching chance to the acceptance
suite then it is a patch version change; if it requires only an addition to
the acceptance suite the it is a minor version change; and if it requires a
modification of existing tests then it is a major version change. That is
not exactly automated but it does give one some hints about what should be
done.

Peter

On May 6, 2014 4:46 PM, "Jeff Lindsay" [email protected] wrote:

Sounds good. Just requires me to pay more attention to PR before doing
releases. Ideas on process that can be automated?

On Tue, May 6, 2014 at 5:00 PM, Peter Williams [email protected]:

The last release included an incompatible change to JWT's interface
which
broke several of my projects. Any chance we could switch to semantic
versioning http://semver.org/ so that consumers of this API don't
unsuspectingly upgrade to incompatible versions?


Reply to this email directly or view it on GitHub<
https://github.com/progrium/ruby-jwt/issues/37>
.

Jeff Lindsay
http://progrium.com


Reply to this email directly or view it on GitHub.

@progrium
Copy link
Contributor

progrium commented May 7, 2014

Alright, semantic versioning from here on out. 0.1.12 was yanked and 1.0.0 was released.

@progrium progrium closed this as completed May 7, 2014
@pezra
Copy link
Author

pezra commented May 7, 2014

Sweet! Thanks a bunch.

On Wed, May 7, 2014 at 8:06 AM, Jeff Lindsay [email protected]:

Closed #37 #37.


Reply to this email directly or view it on GitHubhttps://github.com//issues/37#event-118688794
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants