Allow string hash keys in validation configurations #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Making this a class makes it easier to refactor parts into private methods, additionally it starts paving the way to allowing verification to track failure states and allow the client to handle them without throwing exceptions.
This restores backwards compatibility with 1.5.1 while maintaining compatibility with clients using 1.5.2. Fixes #128
excpt
added a commit
that referenced
this pull request
Feb 24, 2016
Allow string hash keys in validation configurations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Versions prior to 1.5.2 had verification configuration parameters that were mixed strings and symbols, c490860 changed this to exclusively use symbol keys. This change caused verifications that were previously run to not be run. The solution to handle both strings and symbols is a bit hacky but compatibility with both versions was a goal when putting this together.
Fixes #128