Enforce exp to be an Integer
#205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous code was too permissive to accept different types that could be eventually serialized as a number, but that would require that whoever's is decoding the tokens that `exp` could be a `String`.
excpt
approved these changes
Jul 11, 2017
waiting-for-dev
pushed a commit
to waiting-for-dev/warden-jwt_auth
that referenced
this pull request
Oct 23, 2017
2.0.0+ enforce an integer in the payload's exp parameter. One test used an expiration time of 0.01 to simulate an already-expired token, which triggered the raise added in jwt/ruby-jwt#205. A value of -1 accomplishes the same thing and allows the test to pass.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous code was too permissive to accept different types that could be eventually serialized as a number, but that would require that whoever's is decoding the tokens that
expcould be aString.