Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow a list of algorithms for decode #241

Merged
merged 3 commits into from
Oct 5, 2017
Merged

Allow a list of algorithms for decode #241

merged 3 commits into from
Oct 5, 2017

Commits on Oct 5, 2017

  1. Allow a list of algorithms for decode 

    Hard-coding only one algorithms makes rolling out changes harder. Both
ends need to be deployed simultaneously or retry logic needs to
be implemented in app.

Allowing the algorithms to be a list containing potentially multiple
entries enables flexibility when changing algorithms.
    @lautis
    lautis committed Oct 5, 2017
    Configuration menu
    Copy the full SHA
    01c0803 View commit details
    Browse the repository at this point in the history

  2. Fix typo for parameter for test case

    @lautis
    lautis committed Oct 5, 2017
    Configuration menu
    Copy the full SHA
    52e2ed9 View commit details
    Browse the repository at this point in the history

  3. Use either algorithm or algorithms 

    Do not combine both options. As algorithms (plural) option contains
default value, using algorithm (singular) should not include the default
value.
    @lautis
    lautis committed Oct 5, 2017
    Configuration menu
    Copy the full SHA
    538b65d View commit details
    Browse the repository at this point in the history