Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add note about using a hard coded algorithm in README #280

Merged
merged 1 commit into from
Sep 7, 2018

Conversation

revodoge
Copy link
Contributor

@revodoge revodoge commented Sep 2, 2018

I've seen code 'working around' the added security of algorithm parameter by extracting the algorithm from the JWT without verification first, and then passing that algorithm into the JWT verification.

Unfortunately, I don't think there's really a good way to programmatically enforce such a thing. You may be able to require the parameter to be a literal string or a symbol, but I don't know how effective that'd work in practice.

At the very least, I think it's worth adding an additional note in the readme about the algorithm to be more clear for those that don't click into the linked article.

@sourcelevel-bot
Copy link

Hello, @revodoge! This is your first Pull Request that will be reviewed by Ebert, an automatic Code Review service. It will leave comments on this diff with potential issues and style violations found in the code as you push new commits. You can also see all the issues found on this Pull Request on its review page. Please check our documentation for more information.

@excpt excpt self-requested a review September 2, 2018 21:05
@excpt excpt self-assigned this Sep 2, 2018
@excpt excpt added this to the Version 2.2.0 milestone Sep 2, 2018
Copy link
Member

@excpt excpt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for the improvement.

@excpt excpt merged commit 300dbde into jwt:master Sep 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants