Add note about using a hard coded algorithm in README #280
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've seen code 'working around' the added security of algorithm parameter by extracting the algorithm from the JWT without verification first, and then passing that algorithm into the JWT verification.
Unfortunately, I don't think there's really a good way to programmatically enforce such a thing. You may be able to require the parameter to be a literal string or a symbol, but I don't know how effective that'd work in practice.
At the very least, I think it's worth adding an additional note in the readme about the algorithm to be more clear for those that don't click into the linked article.