Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Claims Validation #295

Merged
merged 3 commits into from
Jan 26, 2019
Merged

Claims Validation #295

merged 3 commits into from
Jan 26, 2019

Conversation

jamesstonehill
Copy link
Contributor

@jamesstonehill jamesstonehill commented Jan 26, 2019

This PR refactors the validation of the exp claim and adds validation for the iat and nbf claims. This addresses this feature request.

@jamesstonehill jamesstonehill mentioned this pull request Jan 26, 2019
@sourcelevel-bot
Copy link

Ebert has finished reviewing this Pull Request and has found:

  • 3 possible new issues (including those that may have been commented here).

You can see more details about this review at https://ebertapp.io/github/jwt/ruby-jwt/pulls/295.

@excpt excpt added this to the Version 2.2.0 milestone Jan 26, 2019
@excpt excpt self-requested a review January 26, 2019 14:38
@excpt excpt merged commit faaa3a1 into jwt:master Jan 26, 2019
@excpt
Copy link
Member

excpt commented Jan 26, 2019

Thank you for the time and effort you invested in the last days into this gem! 👍

@jamesstonehill jamesstonehill deleted the claims-validation branch January 26, 2019 17:07
@jamesstonehill
Copy link
Contributor Author

No problem!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants