Force verification of "iss" and "aud" claims #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously when the following options have been provided verify_iss: true, 'iss' => 'acme.org' and the "iss" claim was missing in the payload - no verification was executed. The same was true for "aud". This commit changes the behaviour, so when verify_iss: true, 'iss' => 'acme.org' is set - then the payload is expected to have the "iss" claim and verification will fail if missing. However, ensure to set `verify_iss` to `true`, otherwise the verification is not enabled. This change is backwards compatible, however it might break an app here or there, because previously the verification did not happen as expected. In addition: fixed related test cases and added new ones to ensure to cover all variants.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously when the following options have been provided
and the
"iss"claim was missing in the payload - no verification was executed. The same was true for"aud". This commit changes the behaviour, so whenis set - then the payload is expected to have the "iss" claim and verification will fail if missing. However, ensure to set
verify_isstotrue, otherwise the verification is not enabled.This change is backwards compatible, however it might break an app here or there, because previously the verification did not happen as expected.
In addition: fixed related test cases and added new ones to ensure to cover all variants.
PS: This fixes #81