Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add maven-wrapper and configure CI to use it #490

Merged
merged 1 commit into from
Sep 18, 2019
Merged

Add maven-wrapper and configure CI to use it #490

merged 1 commit into from
Sep 18, 2019

Conversation

bdemers
Copy link
Member

@bdemers bdemers commented Sep 17, 2019

NOTE: also disable verbose artifact download messages (~40% of the log lines)

NOTE: also disable verbose artifact download messages
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 8f8be59 on mvn-wrapper into 5339faf on master.

Copy link
Contributor

@lhazlewood lhazlewood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the benefit of this? Why is it important to add/adopt and maintain this approach moving forward?

I don't ever really use the maven wrapper, so I'm just curious on why it's necessary or valuable. Looking forward to learning!

@bdemers
Copy link
Member Author

bdemers commented Sep 18, 2019

IMHO, the biggest reason is for CI consistency. The version of Maven installed is no longer dependent on what Travis provides (and because of this is less suspectable to any unexpected change of behavior between environments), i.e. we are now pinning the builds to use Maven 3.6.1

By updating to Maven 3.6.1 (we can remove the transfer log spam with the new -no-transfer-progress flag), granted there are other ways to install a given version of Maven, this is just the easiest.

The Maven Wrapper also lowers the barrier of entry for some projects. Assuming you have Java installed you could build any project that uses the wrapper.

@bdemers bdemers merged commit 50fc773 into master Sep 18, 2019
@bdemers bdemers deleted the mvn-wrapper branch September 18, 2019 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants