Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add type hints to core #7

Merged
merged 1 commit into from
Jul 12, 2022
Merged

add type hints to core #7

merged 1 commit into from
Jul 12, 2022

Conversation

jxtngx
Copy link
Owner

@jxtngx jxtngx commented Jul 12, 2022

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Jul 12, 2022

Codecov Report

Merging #7 (4acc9ca) into main (86f12b0) will increase coverage by 0.07%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main       #7      +/-   ##
==========================================
+ Coverage   93.37%   93.45%   +0.07%     
==========================================
  Files           5        5              
  Lines         166      168       +2     
==========================================
+ Hits          155      157       +2     
  Misses         11       11              
Impacted Files Coverage Δ
lightning_pod/core/module.py 79.62% <100.00%> (+0.78%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 86f12b0...4acc9ca. Read the comment docs.

@jxtngx jxtngx merged commit e3a94ad into main Jul 12, 2022
@jxtngx jxtngx deleted the code-quality/core branch September 14, 2022 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants